aight so here's my thoughts, every android phone seems to have a really good thing and a pretty bad thing going for it. None of them are really perfect or are outstandingly better than every other phone.
Pixel 2 + XL - They are pretty decent phones. Main selling point for me is the regular software updates. Something that other droid phones lack is timely security updates. There's no headphone port which is a pretty big stain imo and no SD card slot, however the storage you get as standard is 64GB and I'm not sure if it's still going on but I think you get unlimited storage with full res photos with Google Photos, not sure if it's still a thing. The XL seems to have dropped in price recently as well which is also a pretty neat bonus.
BUT The XL is made by LG who really fucking dropped the ball with the Nexus 5 and have really bad stability problems at around the 1 year mark. However that may not apply to this one yet.
One Plus - They've been going down in my opinion ever since they started to raise their prices even more, kinda sucks as they were a good replacement to the Nexus line where you can get a decent spec phone that has regular software updates. Now you pay the same as any flagship in some cases. They do have somewhat decent software support as their version of Android is kinda just an improved version of the stock OS.
They do however fuck up with security pretty massively which is worth having a look at if you care about that stuff.
Samsung - They have some pretty nice phones but they are doing what Apple do now which is just raise the price of their new phone without doing much in ways of improvement. They are also one of the worst companies out there for software updates.
LG have also had some pretty good phones but they fall the same way as Samsung in terms of software updates, which is a massive shame because the V20 and V30 were fucking good phones. But also they have had a pretty bad reputation in terms of quality with the LG G4 bootloops and the G5 screen burning. They also don't know what phone of theirs will be a flagship either because they just bring out a far superior phone in 6 months time anyway.